Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cargo.toml with edition = "2021" #837

Closed
wants to merge 1 commit into from
Closed

Update Cargo.toml with edition = "2021" #837

wants to merge 1 commit into from

Conversation

nsipplswezey
Copy link
Contributor

Fixes #836

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • [-] I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

cvybhu
cvybhu suggested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@cvybhu cvybhu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK workspaces don't have an edition parameter, I think cargo just ignores it.
I'm against this change if specifying the edition doesn't do anything.

I wrote a longer comment here: #836 (comment)

@nsipplswezey
Copy link
Contributor Author

Agreed! Closing!

@nsipplswezey nsipplswezey deleted the patch-1 branch October 16, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvybhu cvybhu cvybhu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicit edition and resolver in Cargo.toml
2 participants
@nsipplswezey @cvybhu